Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): Fix blank values on Dial API #828

Merged
merged 1 commit into from
May 24, 2023

Conversation

dragonmantank
Copy link
Contributor

Description

The Dial API does not properly handle blank strings ('') versus null values in parameters passed in, so this adds a method and strips the blank strings if they are passed in. This also includes a long overdue whitespace fix

Relevant functions are:

intiateSIPCall()
stripBlankValues()

Motivation and Context

Bug reported in UAT testing the new SDK versus the old OpenTok SDK

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank requested a review from manchuck May 23, 2023 15:22
@dragonmantank dragonmantank force-pushed the fix-video-blank-dial-options branch from c3e04db to 4380d4c Compare May 23, 2023 15:27
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #828 (4380d4c) into 3.x (a9a36c9) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.x     #828      +/-   ##
==========================================
+ Coverage   79.68%   79.81%   +0.12%     
==========================================
  Files          99       99              
  Lines        1265     1273       +8     
  Branches      252      254       +2     
==========================================
+ Hits         1008     1016       +8     
  Misses        256      256              
  Partials        1        1              
Impacted Files Coverage Δ
packages/video/lib/video.ts 83.68% <100.00%> (+0.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dragonmantank dragonmantank merged commit 14ec31f into 3.x May 24, 2023
@dragonmantank dragonmantank deleted the fix-video-blank-dial-options branch May 24, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants