Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring your own passcode #816

Merged
merged 1 commit into from
Apr 25, 2023
Merged

feat: bring your own passcode #816

merged 1 commit into from
Apr 25, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Apr 17, 2023

Adding in bring your own passcode for verify v2

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review April 17, 2023 14:34
@manchuck manchuck requested a review from dragonmantank April 17, 2023 14:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #816 (d998fc0) into 3.x (8ac7c32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #816   +/-   ##
=======================================
  Coverage   78.94%   78.94%           
=======================================
  Files         104      104           
  Lines        1211     1211           
  Branches      234      234           
=======================================
  Hits          956      956           
  Misses        255      255           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit e3f9ecb into 3.x Apr 25, 2023
@manchuck manchuck deleted the feat-verify-byop branch April 25, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants