Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: video client acl #814

Merged
merged 2 commits into from
Apr 4, 2023
Merged

feat: video client acl #814

merged 2 commits into from
Apr 4, 2023

Conversation

dragonmantank
Copy link
Contributor

Description

Added an ACL claim to the client-side JWT tokens for video

Motivation and Context

This will allow client-side tokens proper authorization to video resources

Testing Details

Unit tests, manual tests will be done once this is released

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank requested a review from manchuck April 4, 2023 14:56
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #814 (1f878bf) into 3.x (f10f9e4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #814   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files          86       86           
  Lines        1133     1133           
  Branches      233      233           
=======================================
  Hits          878      878           
  Misses        255      255           
Impacted Files Coverage Δ
packages/video/lib/video.ts 82.70% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dragonmantank dragonmantank requested a review from manchuck April 4, 2023 16:05
@manchuck manchuck changed the title Devx 7217 video client acl feat: video client acl Apr 4, 2023
@dragonmantank dragonmantank merged commit 342d903 into 3.x Apr 4, 2023
@dragonmantank dragonmantank deleted the DEVX-7217-video-client-acl branch April 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants