Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experience composer and captions to video #809

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

dragonmantank
Copy link
Contributor

Description

Adds in the Experience Composer and Captions API calls to the Video SDK

Motivation and Context

These are ready for testing for integration

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank requested a review from manchuck March 23, 2023 15:36
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It just needs bucket files.

https://www.npmjs.com/package/create-index works nicely (or I can walk you through the vim macro)

@manchuck manchuck changed the title Add Experience Composer and Captions to Video SDK feat: add experience composer and captions to video Mar 23, 2023
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dragonmantank dragonmantank merged commit f10f9e4 into 3.x Mar 27, 2023
@dragonmantank dragonmantank deleted the video-exp-composer-captions branch March 27, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants