Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify v2 #805

Merged
merged 3 commits into from
Mar 23, 2023
Merged

feat: verify v2 #805

merged 3 commits into from
Mar 23, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Mar 15, 2023

Adding in Verify v2

Description

This adds in the Verify V2 module

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review March 15, 2023 20:43
@manchuck manchuck requested a review from dragonmantank March 15, 2023 20:43
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify v2 also supports basic header auth, so like with Messages we should support that (it's not a side effect of the auth changes, but a way for customers to still send Verify without setting up an application)

packages/verify2/lib/verify2.ts Show resolved Hide resolved
@manchuck manchuck requested a review from dragonmantank March 23, 2023 18:47
@manchuck manchuck merged commit 08d50bd into 3.x Mar 23, 2023
@manchuck manchuck deleted the verify-plus branch March 23, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants