Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): verify response types #794

Merged
merged 5 commits into from
Feb 27, 2023
Merged

fix(types): verify response types #794

merged 5 commits into from
Feb 27, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Feb 21, 2023 •
edited
Loading

This fixes the typescript interfaces and types for the verify module

Description

I noticed some other issues with some of the types being returned as well as the requests being passed into the verify module. I have addressed them all and updated the tests

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review February 21, 2023 23:06
@manchuck manchuck mentioned this pull request Feb 21, 2023
Closed
dragonmantank
dragonmantank requested changes Feb 24, 2023
View reviewed changes
packages/verify/lib/classes/PSD2.ts Show resolved Hide resolved
packages/verify/lib/classes/PSD2.ts Show resolved Hide resolved
packages/verify/lib/classes/Verification.ts Show resolved Hide resolved
packages/verify/lib/classes/Verification.ts Show resolved Hide resolved
packages/verify/lib/enums/Workflows.ts Outdated Show resolved Hide resolved
packages/verify/lib/verify.ts Show resolved Hide resolved
dragonmantank
dragonmantank approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 888111d into 3.x Feb 27, 2023
@manchuck manchuck deleted the fix-verify-interfaces branch February 27, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmantank dragonmantank dragonmantank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @dragonmantank