Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: meetings package #788

Merged
merged 2 commits into from
Jun 23, 2023
Merged

feat: meetings package #788

merged 2 commits into from
Jun 23, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jan 23, 2023

Adding the meetings API

Description

This adds the meetings API calls to the SDK.

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck force-pushed the meetings-package branch 3 times, most recently from 11214fd to e7a9007 Compare January 25, 2023 21:54
@manchuck manchuck changed the title Meetings package feat: meetings package Jan 25, 2023
@manchuck manchuck marked this pull request as ready for review January 25, 2023 22:22
@manchuck manchuck removed the request for review from abdulajet January 25, 2023 22:22
@manchuck manchuck force-pushed the meetings-package branch 2 times, most recently from cd7477a to 408bea6 Compare January 30, 2023 18:29
@manchuck manchuck added the don't merge Don't merge this code at this time label Feb 9, 2023
@ziahamza
Copy link

@manchuck whats still left in this PR to wrap up? Would love to see this get merged 🚢

@manchuck
Copy link
Contributor Author

@ziahamza We have put this release on hold as our internal team is working on changes to the API endpoints, which might not be compatible with the current meetings API specification. Once those changes have been released, we will work on updating the SDK.

@manchuck manchuck force-pushed the meetings-package branch 2 times, most recently from 47df50c to 19569b8 Compare June 22, 2023 20:47
@manchuck manchuck removed the don't merge Don't merge this code at this time label Jun 22, 2023
@manchuck manchuck requested a review from Tr00d June 22, 2023 20:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #788 (2c3ccb3) into 3.x (e50c7cb) will increase coverage by 1.51%.
The diff coverage is 97.54%.

@@            Coverage Diff             @@
##              3.x     #788      +/-   ##
==========================================
+ Coverage   80.06%   81.57%   +1.51%     
==========================================
  Files          99      100       +1     
  Lines        1289     1411     +122     
  Branches      257      280      +23     
==========================================
+ Hits         1032     1151     +119     
- Misses        256      259       +3     
  Partials        1        1              
Impacted Files Coverage Δ
packages/meetings/lib/meetings.ts 97.52% <97.52%> (ø)
packages/server-client/lib/client.ts 98.43% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck requested a review from Tr00d June 23, 2023 13:49
@manchuck manchuck merged commit de69d5a into 3.x Jun 23, 2023
@manchuck manchuck deleted the meetings-package branch June 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants