Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: audit package #787

Merged
merged 9 commits into from
Jan 17, 2023
Merged

feat: audit package #787

merged 9 commits into from
Jan 17, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Jan 12, 2023 •
edited
Loading

Adding the Audit module

Description

Creating a new package for interacting with the audit API. I also added some transform functions for objects as I noticed the same functionality was duplicated in other places and won't go deep into the object. These functions have been added to server-client along with a new type that defines our API links

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review January 12, 2023 22:26
@manchuck manchuck requested a review from abdulajet January 13, 2023 18:23
dragonmantank
dragonmantank requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking some things out, and removing Audit as an actual dependency

packages/audit/lib/enums.ts Show resolved Hide resolved
packages/audit/lib/types.ts Outdated Show resolved Hide resolved
packages/server-sdk/lib/vonage.ts Show resolved Hide resolved
packages/server-sdk/package.json Show resolved Hide resolved
dragonmantank
dragonmantank approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 882f800 into 3.x Jan 17, 2023
@manchuck manchuck deleted the audit-package branch January 17, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmantank dragonmantank dragonmantank approved these changes

@abdulajet abdulajet Awaiting requested review from abdulajet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manchuck @dragonmantank