Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct our return types when sending SMS #743

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

dragonmantank
Copy link
Contributor

Description

Corrects the type definition for the returned SMS responses to match the original declaration. This also adds keys with appropriate deprecation notices to not break existing code.

Motivation and Context

Per #742 , the definitions we provided for the return response did not match the API. Looks like as this was an early module, we never finished cleaning up to make it match.

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the test

packages/sms/__tests__/sms.test.ts Show resolved Hide resolved
Copy link
Contributor

@manchuck manchuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with it for now, and when we add in the linter rules, we can most likely make it an exception if it bugs out

@dragonmantank dragonmantank merged commit 7d9fc80 into 3.x Nov 30, 2022
@dragonmantank dragonmantank deleted the fix-sms-send-returns branch November 30, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants