Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): GHA install typescript before running build commands #737

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

dragonmantank
Copy link
Contributor

@dragonmantank dragonmantank commented Nov 21, 2022

Description

Fixes to make the build process work with 1) a monorepo and 2) Windows

Motivation and Context

Because knowing the status of your build is important

Testing Details

act and seeing the action in the Actions tab

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

manchuck
manchuck previously approved these changes Nov 21, 2022
@manchuck manchuck changed the title fix: GHA install typescript before running build commands fix(build): GHA install typescript before running build commands Nov 21, 2022
@dragonmantank dragonmantank merged commit 504be6a into 3.x Nov 21, 2022
@dragonmantank dragonmantank deleted the actions-test-crt branch November 21, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants