fix: Change Numbers API to make URL Form Encoded requests #734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the POST requests of the Numbers API to use URL form encoded requests instead of JSON bodies. Also forced the Numbers API to make sure the API Key and Secret are always in the header via the correct auth type.
Motivation and Context
Looks like this was a long-standing bug with the v3 code, and when everything was transitioned to using the
server-client
package it was moved to normal POST requests with a JSON body instead of using form encoded requests.Testing Details
Unit tests, and used in a demo app
Example Output or Screenshots (if appropriate)
Types of changes
Checklist