Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow features to be searched in available numbers #731

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

dragonmantank
Copy link
Contributor

Description

Searching for available numbers did not allow searching by feature, so added that. Also added some helper enums for searching to make understanding the options better.

Searching by feature also makes sure that the options are always in the correct order.

Motivation and Context

When working on a demo, I could not search by feature so needed this.

The additional enums make it easier to understand what some of the options are.

The feature sorting also removes the need for the developer to know what order to put the features in, the SDK will re-order them. The developer just needs to chuck the features into an array, everything else is handled.

Testing Details

Unit tests

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank merged commit 5b4b201 into 3.x Nov 17, 2022
@dragonmantank dragonmantank deleted the fix-numbers-search-did-not-allow-features branch November 17, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant