feat: bring your own passcode (#816)

Vonage · Apr 25, 2023 · e3f9ecb · e3f9ecb
1 parent 82399a4
commit e3f9ecb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/packages/verify2/__tests__/__dataSets__/verify.ts b/packages/verify2/__tests__/__dataSets__/verify.ts
@@ -259,6 +259,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -283,6 +284,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {
@@ -306,6 +308,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -329,6 +332,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {
@@ -352,6 +356,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -375,6 +380,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {
@@ -398,6 +404,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -421,6 +428,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {
@@ -444,6 +452,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -467,6 +476,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {
@@ -490,6 +500,7 @@ export default [
               channel_timeout: 300,
               client_ref: 'my-ref',
               code_length: 4,
+              code: '4242',
             } as VerificationRequest,
     ],
     response: [
@@ -513,6 +524,7 @@ export default [
               channelTimeout: 300,
               clientRef: 'my-ref',
               codeLength: 4,
+              code: '4242',
             } as VerificationRequestParams,
     ],
     expected: {

diff --git a/packages/verify2/lib/types/verifcationRequest.ts b/packages/verify2/lib/types/verifcationRequest.ts
@@ -6,20 +6,17 @@ import { VoiceWorkflow } from './voiceWorkflow';
 import { WhatsAppInteractiveWorkflow } from './whatsAppInteractiveWorkflow';
 import { WhatsAppWorkflow } from './whatsAppWorkflow';
 
-type SMSWorkFlowRequest = {
-    app_has: string
-} & Omit<SMSWorkflow, 'appHash'>
-
 export type VerificationRequest = {
     brand: string
     workflow: Array<
         | EmailWorkflow
-        | SMSWorkFlowRequest
+        | (Omit<SMSWorkflow, 'appHash'> & { app_hash: string })
         | SilentAuthWorkflow
         | VoiceWorkflow
         | WhatsAppInteractiveWorkflow
         | WhatsAppWorkflow
     >
+    code?: string
     locale?: VerifyLocale
     channel_timeout?: number
     client_ref?: string

diff --git a/packages/verify2/lib/types/verifcationRequestParams.ts b/packages/verify2/lib/types/verifcationRequestParams.ts
@@ -16,6 +16,7 @@ export type VerificationRequestParams = {
         | WhatsAppInteractiveWorkflow
         | WhatsAppWorkflow
     >
+    code?: string
     locale?: VerifyLocale
     channelTimeout?: number
     clientRef?: string