fix(voice): Fixed response types on file downloads (#864)

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ jobs:
           node-version: ${{ matrix.node }}
 
       - name: Install typescript
-        run: npm install -g typescript npm${{ matrix.npm_version }}
+        run: npm install -g typescript
 
       - name: Install packages
         run: npm install

packages/proactive-connect/package.json

@@ -28,7 +28,6 @@
   },
   "dependencies": {
     "@vonage/server-client": "^1.8.1",
-    "@vonage/vetch": "1.5.0",
     "form-data": "^4.0.0",
     "lodash.pick": "^4.4.0"
   },

packages/server-client/lib/client.ts

@@ -5,6 +5,7 @@ import {
   VetchResponse,
   VetchOptions,
   HTTPMethods,
+  Vetch,
 } from '@vonage/vetch';
 import { AuthenticationType } from './enums/AuthenticationType';
 import * as transfomers from './transformers';
@@ -174,7 +175,8 @@ export abstract class Client {
   ): Promise<VetchResponse<T>> {
     request.timeout = this.config.timeout;
     request = await this.addAuthenticationToRequest(request);
-    const result = await vetchRequest<T>(request);
+    const vetch = new Vetch(this.config);
+    const result = await vetch.request<T>(request);
     return result;
   }
 }

packages/server-client/lib/types/ConfigParams.ts

@@ -1,8 +1,9 @@
+import { ResponseTypes } from '@vonage/vetch';
 export type ConfigParams = {
   restHost?: string;
   apiHost?: string;
   videoHost?: string;
-  responseType?: string;
+  responseType?: ResponseTypes;
   timeout?: number;
   proactiveHost?: string;
   meetingsHost?: string;

packages/vetch/lib/enums/responseTypes.ts

@@ -1,3 +1,5 @@
 export enum ResponseTypes {
-    json = 'json',
+  json = 'json',
+  stream = 'stream',
+  text = 'text',
 }

packages/vetch/lib/vetch.ts

@@ -69,6 +69,8 @@ export class Vetch {
     res: fetchResponse,
   ): Promise<any> {
     switch (opts.responseType) {
+    case 'stream':
+      return res.buffer();
     case 'json': {
       let data = await res.text();
       try {

packages/voice/lib/voice.ts

@@ -14,6 +14,7 @@ import {
 } from './types/index';
 
 import { CallListFilter } from './types';
+import { ResponseTypes } from '@vonage/vetch';
 
 const apiCallsToCalls = (call: CallDetailResponse): CallDetail => {
   delete call._links;
@@ -177,8 +178,18 @@ export class Voice extends Client {
   }
 
   async downloadRecording(file: string, path: string): Promise<void> {
-    const client = new FileClient(this.auth, this.config);
+    const config = this.config;
+    config.responseType = ResponseTypes.stream;
 
+    const client = new FileClient(this.auth, config);
+    return await client.downloadFile(file, path);
+  }
+
+  async downloadTranscription(file: string, path: string): Promise<void> {
+    const config = this.config;
+    config.responseType = ResponseTypes.text;
+
+    const client = new FileClient(this.auth, config);
     return await client.downloadFile(file, path);
   }