Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate support for ERC20 tokens #15

Open
federicobond opened this issue Feb 22, 2018 · 7 comments
Open

Investigate support for ERC20 tokens #15

federicobond opened this issue Feb 22, 2018 · 7 comments
Assignees

Comments

@federicobond
Copy link
Collaborator

No description provided.

@shogochiai
Copy link

What is this token for? Deposited ETH on Plasma chain?
So the PlasmaETH will be ERC-20 token?
I wanna know some underlying discussion.

@jdkanani
Copy link
Contributor

jdkanani commented Mar 13, 2018

Current implementation - master branch - supports ETH. You deposit ETH and use PlasmaCoin as ETH on plasma chain.

This pull request #17 implements token ERC20 instead of ETH. You can deposit defined token (check constructor argument which defines main chain's token address https://github.com/jdkanani/plasma/blob/c189d9808763abe69067277c66dab55b66187c4f/contracts/RootChain.sol#L82) and PlasmaCoin will represent that token on plasma chain.

@shogochiai
Copy link

Okay so on master, both deposit and PlasmaCoin are ETH.
On PR #17, deposit is ETH and PlasmaCoin is "PlasmaWP-mentioned block withholding attack desincentivizing token".

So this ERC-20 token must be used for transaction fee, and PoS validation reward, right?

@federicobond
Copy link
Collaborator Author

With #17 you can deposit tokens from an ERC-20 compatible token contract defined in the RootChain constructor a get a UTXO for that token in the Plasma chain.

@shogochiai
Copy link

Deposit is gonna be arbitrary ERC-20 token, PlasmaCoin will represent that Plasma chain's token, okay.

And this PlasmaCoin will be re-implemented on each child Plasma chain, but this repo is gonna be template/framework for building offspring chains, hence no need to reinvent wheel, right?

@federicobond
Copy link
Collaborator Author

That's right, a new contract instance must be deployed for each token you want to support.

@shogochiai
Copy link

The rootchain is expensive, hence for example nth-depth PlasmaChain's PlasmaCoin(ERC-20 based) is not able to be processed & defined on the rootchain contract.

Then I guestimated that (n-1)th PlasmaChain might have an ability to define Plasma contract for nth PlasmaChain, and this PlasmaCoin is not defined on the rootchain.

For enabling that, this repo must have EVM to define&process PlasmaContract, rather thab on the rootchain PlasmaContract. CMIIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants