Skip to content

Commit 352ca26

Browse files
authored
Merge pull request #1620 from volta-cli/push-ovqmzpsuslzn
Correctly (locally) test Node architecture fallback
2 parents 75c0d0d + 1f4585a commit 352ca26

File tree

1 file changed

+27
-3
lines changed
  • crates/volta-core/src/tool/node

1 file changed

+27
-3
lines changed

crates/volta-core/src/tool/node/mod.rs

+27-3
Original file line numberDiff line numberDiff line change
@@ -259,18 +259,42 @@ mod tests {
259259
#[test]
260260
fn test_node_archive_basename() {
261261
assert_eq!(
262-
Node::archive_basename(&Version::parse("1.2.3").unwrap()),
263-
format!("node-v1.2.3-{}-{}", NODE_DISTRO_OS, NODE_DISTRO_ARCH)
262+
Node::archive_basename(&Version::parse("16.2.3").unwrap()),
263+
format!("node-v16.2.3-{}-{}", NODE_DISTRO_OS, NODE_DISTRO_ARCH)
264264
);
265265
}
266266

267267
#[test]
268268
fn test_node_archive_filename() {
269+
assert_eq!(
270+
Node::archive_filename(&Version::parse("16.2.3").unwrap()),
271+
format!(
272+
"node-v16.2.3-{}-{}.{}",
273+
NODE_DISTRO_OS, NODE_DISTRO_ARCH, NODE_DISTRO_EXTENSION
274+
)
275+
);
276+
}
277+
278+
#[test]
279+
#[cfg(all(target_os = "macos", target_arch = "aarch64"))]
280+
fn test_fallback_node_archive_basename() {
281+
assert_eq!(
282+
Node::archive_basename(&Version::parse("1.2.3").unwrap()),
283+
format!(
284+
"node-v1.2.3-{}-{}",
285+
NODE_DISTRO_OS, NODE_DISTRO_ARCH_FALLBACK
286+
)
287+
);
288+
}
289+
290+
#[test]
291+
#[cfg(all(target_os = "macos", target_arch = "aarch64"))]
292+
fn test_fallback_node_archive_filename() {
269293
assert_eq!(
270294
Node::archive_filename(&Version::parse("1.2.3").unwrap()),
271295
format!(
272296
"node-v1.2.3-{}-{}.{}",
273-
NODE_DISTRO_OS, NODE_DISTRO_ARCH, NODE_DISTRO_EXTENSION
297+
NODE_DISTRO_OS, NODE_DISTRO_ARCH_FALLBACK, NODE_DISTRO_EXTENSION
274298
)
275299
);
276300
}

0 commit comments

Comments
 (0)