Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volcano support Kubernetes v1.30 #3523

Closed
william-wang opened this issue Jun 14, 2024 · 9 comments · Fixed by #3556
Closed

Volcano support Kubernetes v1.30 #3523

william-wang opened this issue Jun 14, 2024 · 9 comments · Fixed by #3556
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@william-wang
Copy link
Member

What would you like to be added:

Support Volcano runnng on Kubernetes v1.30 in production.

Why is this needed:

Kubernetes v1.30 is ready to use, Volcano is required to support it.

@william-wang william-wang added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 14, 2024
@wangyysde
Copy link
Contributor

/assign

I want to try this

@Monokaix
Copy link
Member

/assign

I want to try this

Welcome! Please refer to https://github.com/volcano-sh/volcano/blob/master/docs/design/adapt-k8s-todo.md.

@wangyysde
Copy link
Contributor

/assign
I want to try this

Welcome! Please refer to https://github.com/volcano-sh/volcano/blob/master/docs/design/adapt-k8s-todo.md.

OK, Thank you very much.

@googs1025
Copy link
Member

googs1025 commented Jun 16, 2024

Do we need to have forward compatibility with previous versions of Kubernetes when performing e2e tests? For example, do we need to ensure compatibility not only with version 1.30 but also with versions 1.27, 1.28, and 1.29?

@Monokaix
Copy link
Member

Do we need to have forward compatibility with previous versions of Kubernetes when performing e2e tests? For example, do we need to ensure compatibility not only with version 1.30 but also with versions 1.27, 1.28, and 1.29?

just test with the version we will support is ok.

@googs1025
Copy link
Member

Do we need to have forward compatibility with previous versions of Kubernetes when performing e2e tests? For example, do we need to ensure compatibility not only with version 1.30 but also with versions 1.27, 1.28, and 1.29?

just test with the version we will support is ok.

Yes, I understand that we only need to support version 1.30. What I mean is whether, in the long run, we should introduce tests for multiple versions in our e2e testing. This is because we are unsure if changes made in a pull request might impact previous versions. For example, if I submit a pull request that passes the kind e2e tests for version 1.30, it may not pass in versions 1.28 and 1.27.

@Monokaix
Copy link
Member

Monokaix commented Jun 17, 2024

Do we need to have forward compatibility with previous versions of Kubernetes when performing e2e tests? For example, do we need to ensure compatibility not only with version 1.30 but also with versions 1.27, 1.28, and 1.29?

just test with the version we will support is ok.

Yes, I understand that we only need to support version 1.30. What I mean is whether, in the long run, we should introduce tests for multiple versions in our e2e testing. This is because we are unsure if changes made in a pull request might impact previous versions. For example, if I submit a pull request that passes the kind e2e tests for version 1.30, it may not pass in versions 1.28 and 1.27.

You're right, it's better to cover all versions: )

@googs1025
Copy link
Member

Do we need to have forward compatibility with previous versions of Kubernetes when performing e2e tests? For example, do we need to ensure compatibility not only with version 1.30 but also with versions 1.27, 1.28, and 1.29?

just test with the version we will support is ok.

Yes, I understand that we only need to support version 1.30. What I mean is whether, in the long run, we should introduce tests for multiple versions in our e2e testing. This is because we are unsure if changes made in a pull request might impact previous versions. For example, if I submit a pull request that passes the kind e2e tests for version 1.30, it may not pass in versions 1.28 and 1.27.

You're right, it's better to cover all versions: )

Yes, I will follow up on this matter and raise an issue to track it after other PRs have progressed to a certain extent.

@guoqinwill
Copy link
Contributor

/assign

I want to try this

Thank you!But please note to control the pace, as the commercial version of Volcano relies on the community version for upgrades. We expect the community version to complete the adaptation by mid-July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
5 participants