Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline bug in getDiffedLines #8

Closed
andrewpareles opened this issue Sep 17, 2024 · 1 comment
Closed

Fix newline bug in getDiffedLines #8

andrewpareles opened this issue Sep 17, 2024 · 1 comment
Milestone

Comments

@andrewpareles
Copy link
Contributor

andrewpareles commented Sep 17, 2024

We define a "diff" as a single green/red pair that denotes a change.

We create diffs by using the function getDiffedLines, which takes in an old string and the new string and outputs the information of each diff (the range of the diff, the original text of the diff, etc).
Right now, getDiffedLines occasionally outputs the wrong number of newlines. We think this caused by inconsistencies in diffLines:

image

Here is an example of the bug:
image

@andrewpareles andrewpareles added this to the release #1 milestone Sep 17, 2024
@andrewpareles andrewpareles moved this to Good for Starters in 🚙 Void Roadmap Sep 17, 2024
@andrewpareles andrewpareles moved this to Good for Starters in 🚙 Void Roadmap Sep 17, 2024
@andrewpareles andrewpareles closed this as completed by moving to Medium in 🚙 Void Roadmap Sep 17, 2024
@andrewpareles andrewpareles reopened this Sep 17, 2024
@andrewpareles andrewpareles changed the title Fix bug in getDiffedLines Fix newline bug in getDiffedLines Sep 17, 2024
@andrewpareles
Copy link
Contributor Author

This is really part of #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant