Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diffs on changes #15

Closed
andrewpareles opened this issue Sep 17, 2024 · 6 comments
Closed

Update diffs on changes #15

andrewpareles opened this issue Sep 17, 2024 · 6 comments
Assignees
@mathewpareles
Milestone
release #1

Comments

@andrewpareles
Copy link
Contributor

When the user presses "Accept" or "Reject" on a diff, all of the diffs below should be updated, because they are now on different line numbers.
@andrewpareles andrewpareles moved this to Good First Issues in 🚙 Void Roadmap Sep 17, 2024
@andrewpareles andrewpareles added this to the release #1 milestone Sep 17, 2024
@mathewpareles mathewpareles changed the title Update diffs on accept/reject Update lower diffs Sep 18, 2024
@mathewpareles mathewpareles changed the title Update lower diffs Update diffs on changes Sep 19, 2024
@liamstamper
Copy link

can i be assigned this?

@liamstamper
Copy link

and can i have more info

@eliphazbouye
Copy link

@liamstamper just do it and send PR

@avinpy-255
Copy link

Hi @andrewpareles,

I've implemented the diff updates after pressing "Accept" or "Reject." The diffs now adjust based on the updated line numbers. I tested this and attached a video. Please review and let me know your feedback!

Screencast.from.2024-09-20.17-39-50.webm

@andrewpareles
Copy link
Contributor Author

Did you push any code? I'm not sure what this video is showing.

@andrewpareles
Copy link
Contributor Author

andrewpareles commented Oct 15, 2024 •
edited
Loading

Thanks @mathewpareles!

@mathewpareles mathewpareles mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathewpareles mathewpareles

Labels
None yet
Projects
None yet
Milestone
release #1
Development

No branches or pull requests
5 participants
@andrewpareles @mathewpareles @eliphazbouye @avinpy-255 @liamstamper