Cherry-pick: Publish artifacts from release branches separately (#8062) #8159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the build-ova.sh script used by vic-product to create the unified OVA picks the most recent build uploaded to vic-engine-builds. Because builds from all branches are written to the same directory, this can lead to unexpected combinations of components being assembled into an OVA. To allow downstream jobs more reliably consume desired dependencies, publish artifacts from release branches into sub-directories of a releases directory. This alone will improve the behavior of downstream builds expecting to consume dependencies from master. With additional changes, this can be leveraged to allow push builds on release branches to behave more like push builds on master: consuming the most up-to-date build from the appropriate branch of the upstream. Update jenkins-nightly-run.sh to allow download of builds published to release branch directories. Additionally, publish artifacts from PR builds into separate bucket. (cherry picked from commit 00d377d)
hickeng
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the build-ova.sh script used by vic-product to create the
unified OVA picks the most recent build uploaded to vic-engine-builds.
Because builds from all branches are written to the same directory,
this can lead to unexpected combinations of components being assembled
into an OVA.
To allow downstream jobs more reliably consume desired dependencies,
publish artifacts from release branches into sub-directories of a
releases directory.
This alone will improve the behavior of downstream builds expecting to
consume dependencies from master. With additional changes, this can be
leveraged to allow push builds on release branches to behave more like
push builds on master: consuming the most up-to-date build from the
appropriate branch of the upstream.
Update jenkins-nightly-run.sh to allow download of builds published to
release branch directories.
Additionally, publish artifacts from PR builds into separate bucket.
(cherry picked from commit 00d377d)