Pin busybox version for nslookup #8157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeng
force-pushed
the
busybox-nslookup-link-alias
branch
from
05359c1
to
d8935be
Compare
lcastellano
approved these changes
Jul 26, 2018
Busybox ping exhibited intermittent failures some time back so we had switched to using the debian image for ping testing, however in the recent past we are now seeing intermittent failures in the busybox nslookup results as well. This appears to be dependent on the order in which A and AAAA record query results are returned as those queries appear to be issued in parallel. The debian nslookup does not issue an AAAA query by default and does not exhibit this problem however nslookup is also not available in the base image. As such we're pinning the busybox version to one with a functioning nslookup until https://bugs.busybox.net/show_bug.cgi?id=11161 is addressed.
hickeng
force-pushed
the
busybox-nslookup-link-alias
branch
from
d8935be
to
b5919ac
Compare
hickeng
changed the title
zjs
approved these changes
Jul 26, 2018
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
Busybox ping exhibited intermittent failures some time back so we had switched to using the debian image for ping testing, however in the recent past we are now seeing intermittent failures in the busybox nslookup results as well. This appears to be dependent on the order in which A and AAAA record query results are returned as those queries appear to be issued in parallel. The debian nslookup does not issue an AAAA query by default and does not exhibit this problem however nslookup is also not available in the base image. As such we're pinning the busybox version to one with a functioning nslookup until https://bugs.busybox.net/show_bug.cgi?id=11161 is addressed. (cherry picked from commit 24af8e8)
zjs
added a commit
that referenced
this pull request
Jul 27, 2018
Busybox ping exhibited intermittent failures some time back so we had switched to using the debian image for ping testing, however in the recent past we are now seeing intermittent failures in the busybox nslookup results as well. This appears to be dependent on the order in which A and AAAA record query results are returned as those queries appear to be issued in parallel. The debian nslookup does not issue an AAAA query by default and does not exhibit this problem however nslookup is also not available in the base image. As such we're pinning the busybox version to one with a functioning nslookup until https://bugs.busybox.net/show_bug.cgi?id=11161 is addressed. (cherry picked from commit 24af8e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Busybox ping exhibited intermittent failures some time back so we had
switched to using the debian image for ping testing, however we are now
seeing intermittent failures in the busybox nslookup results as well.
This appears to be dependent on the order in which A and AAAA record query
results are returned as those queries appear to be issued in parallel.
The debian nslookup does not issue an AAAA query by default and does not
exhibit this problem however is not available in the base image. As such we've
pinned the busybox version to 1.28.4 until the bug is fixed.
See docker-library/busybox#48
Also updates all images used in the test to use the image variable rather than
hardcoded names so we use the local mirrors if configured.