C reproducer for range delete issue

Author: rosenhouse

Makefile

@@ -242,6 +242,9 @@ BTREE_SYS = $(OBJDIR)/$(SRCDIR)/btree.o           \
 # Note each test bin/unit/<x> also depends on obj/unit/<x>.o, as
 # defined above using unit_test_self_dependency.
 #
+$(BINDIR)/repro_bug_range_delete: $(OBJDIR)/repro_bug_range_delete.o $(LIBDIR)/libsplinterdb.so
+	$(LD) $(LDFLAGS) -o $@ $^ $(LIBS)
+
 $(BINDIR)/$(UNITDIR)/misc_test: $(UTIL_SYS)
 
 $(BINDIR)/$(UNITDIR)/util_test: $(UTIL_SYS)

include/splinterdb/limits.h

@@ -11,8 +11,8 @@
 #ifndef __LIMITS_H__
 #define __LIMITS_H__
 
-#define MAX_KEY_SIZE     24  /* bytes */
-#define MAX_MESSAGE_SIZE 128 /* bytes */
+#define MAX_KEY_SIZE     48  /* bytes */
+#define MAX_MESSAGE_SIZE 216 /* bytes */
 #define MAX_KEY_STR_LEN  128 /* bytes */
 
 #endif // __LIMITS_H__

repro_bug_range_delete.c

@@ -0,0 +1,108 @@
+// Copyright 2021 VMware, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+#include "splinterdb/splinterdb.h"
+#include "splinterdb/default_data_config.h"
+#include "tests/unit/unit_tests.h"
+#include "tests/functional/random.h"
+
+#define KEY_SIZE   (MAX_KEY_SIZE - 8)
+#define VALUE_SIZE 200
+
+#define ASSERT_EQUAL(a, b) platform_assert((a) == (b))
+
+static uint32
+naive_range_delete(const splinterdb *kvsb,
+                   char             *start_key,
+                   size_t            start_key_len,
+                   uint32            count)
+{
+   fprintf(stderr, "\tcollecting keys to delete...\n");
+   char *keys_to_delete = calloc(count, KEY_SIZE);
+
+   splinterdb_iterator *it;
+   int rc = splinterdb_iterator_init(kvsb, &it, start_key_len, start_key);
+   ASSERT_EQUAL(0, rc);
+
+   const char *key;
+   const char *val;
+   size_t      key_len, val_len;
+   uint32      num_found = 0;
+   for (; splinterdb_iterator_valid(it); splinterdb_iterator_next(it)) {
+      splinterdb_iterator_get_current(it, &key_len, &key, &val_len, &val);
+      ASSERT_EQUAL(KEY_SIZE, key_len);
+      memcpy(keys_to_delete + num_found * KEY_SIZE, key, KEY_SIZE);
+      num_found++;
+      if (num_found >= count) {
+         break;
+      }
+   }
+   rc = splinterdb_iterator_status(it);
+   ASSERT_EQUAL(0, rc);
+   splinterdb_iterator_deinit(it);
+
+   fprintf(stderr, "\tdeleting collected keys...\n");
+   for (uint32 i = 0; i < num_found; i++) {
+      char *key_to_delete = keys_to_delete + i * KEY_SIZE;
+      splinterdb_delete(kvsb, KEY_SIZE, key_to_delete);
+   }
+
+   free(keys_to_delete);
+   return num_found;
+}
+
+static void
+uniform_random_inserts(const splinterdb *kvsb,
+                       uint32            count,
+                       random_state     *rand_state)
+{
+   char key_buffer[KEY_SIZE]     = {0};
+   char value_buffer[VALUE_SIZE] = {0};
+
+   for (uint32 i = 0; i < count; i++) {
+      random_bytes(rand_state, key_buffer, KEY_SIZE);
+      random_bytes(rand_state, value_buffer, VALUE_SIZE);
+      int rc = splinterdb_insert(
+         kvsb, KEY_SIZE, key_buffer, VALUE_SIZE, value_buffer);
+      ASSERT_EQUAL(0, rc);
+   }
+}
+
+
+int
+main()
+{
+   splinterdb_config cfg = (splinterdb_config){
+      .filename   = "db",
+      .cache_size = 3 * Giga,
+      .disk_size  = 128 * Giga,
+   };
+   default_data_config_init(KEY_SIZE, VALUE_SIZE, &cfg.data_cfg);
+
+   splinterdb *kvsb;
+
+   int rc = splinterdb_create(&cfg, &kvsb);
+   ASSERT_EQUAL(0, rc);
+
+   random_state rand_state;
+   random_init(&rand_state, 42, 0);
+
+   const uint32 num_inserts = 5 * 1000 * 1000;
+   fprintf(stderr, "loading data...\n");
+   uniform_random_inserts(kvsb, num_inserts, &rand_state);
+   fprintf(stderr, "loaded %u k/v pairs\n", num_inserts);
+
+   uint32 num_rounds = 5;
+   for (uint32 round = 0; round < num_rounds; round++) {
+      fprintf(stderr, "range delete round %d...\n", round);
+      char start_key[4];
+      random_bytes(&rand_state, start_key, sizeof(start_key));
+      const uint32 num_to_delete = num_inserts / num_rounds;
+
+      uint32 num_deleted =
+         naive_range_delete(kvsb, start_key, sizeof(start_key), num_to_delete);
+      fprintf(stderr, "\tdeleted %u k/v pairs\n", num_deleted);
+   }
+
+   splinterdb_close(kvsb);
+}