Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recheck for Invoke-VcfHealthReport to check for tar if running Windows #190

Closed
1 of 4 tasks
burnsjared0415 opened this issue Nov 16, 2023 · 2 comments · Fixed by #191
Closed
1 of 4 tasks

Add a recheck for Invoke-VcfHealthReport to check for tar if running Windows #190

burnsjared0415 opened this issue Nov 16, 2023 · 2 comments · Fixed by #191
Assignees
Labels
enhancement Enhancement
Milestone

Comments

@burnsjared0415
Copy link
Contributor

burnsjared0415 commented Nov 16, 2023

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

If for some reason you don't read the Requirements for the Module and just run the command, you will get some error messages that don't example the issue of missing the tar.exe file in c:\windows\System32. I suggest adding code to stop the run with a error message right at the beginning.

Use Case(s)

Older Operating Systems that are not in Requirements list

Potential Configuration

Function Invoke-VcfHealthReport {
   <#
      ...

   Try {
       Clear-Host; Write-Host ""
          
          if ($PSVersionTable.PSEdition -eq "Desktop" -or $PSVersionTable.OS -like "Microsoft Windows*") {
           $tarPath = (Get-Command tar -ErrorAction SilentlyContinue).Source
           if (!($tarPath)) {
               Write-Warning "The tar utility is required to run this cmdlet. Please check the module system requirements and try again."
               return
           }
       } 

      .....

References

No response

@burnsjared0415 burnsjared0415 added enhancement Enhancement needs-review Needs Review labels Nov 16, 2023
@github-actions github-actions bot added the pending-review Pending Review label Nov 16, 2023
@tenthirtyam tenthirtyam changed the title updated Invoke-VCFHealthReport module to allow for error handling around missing OS requirement section Add a recheck for Invoke-VcfHealthReport to check for tar if running Windows Nov 16, 2023
@tenthirtyam tenthirtyam removed needs-review Needs Review pending-review Pending Review labels Nov 16, 2023
@tenthirtyam tenthirtyam added this to the v2.5.0 milestone Nov 16, 2023
@tenthirtyam
Copy link
Collaborator

Resolved in #191.

Copy link

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement
Projects
None yet
2 participants