Add fields for Egress information support #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamtalen
force-pushed
the
add-egress-policy
branch
from
c561545
to
82ba519
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 73.52% 73.54% +0.01%
==========================================
Files 18 18
Lines 2784 2786 +2
==========================================
+ Hits 2047 2049 +2
Misses 572 572
Partials 165 165
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
reviewed
Jun 6, 2023
pkg/intermediate/aggregate.go
Outdated
Comment on lines
342
to
344
| // Ignore records from the Egress node for Pod-to-External flows | ||
| // if the Egress node is not the same as the Source node. | ||
| if isRecordFromEgressNode(flowType, record) { |
There was a problem hiding this comment.
why don't we skip sending it from the Agent instead?
There was a problem hiding this comment.
Thanks Antonin bringing it up, I misunderstood the words from Srikar 'at Egress node' as 'from Egress node.' I agree skip sending it from the Agent is a better approach.
Add two new fields egressName and egressIP for the visibility of Egress information in flow records. Signed-off-by: Yongming Ding <[email protected]>
dreamtalen
force-pushed
the
add-egress-policy
branch
from
82ba519
to
18cd262
Compare
dreamtalen
changed the title
dreamtalen
changed the title
antoninbas
approved these changes
Jun 7, 2023
heanlan
approved these changes
Jun 7, 2023
dreamtalen
added a commit
to dreamtalen/go-ipfix
that referenced
this pull request
Jun 7, 2023
Add two new fields egressName and egressIP for the visibility of Egress information in flow records. Signed-off-by: Yongming Ding <[email protected]>
dreamtalen
added a commit
that referenced
this pull request
Jun 7, 2023
Add two new fields egressName and egressIP for the visibility of Egress information in flow records. Signed-off-by: Yongming Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new fields egressName and egressIP for the visibility of Egress information in flow records.
Changes in Antrea: antrea-io/antrea#5088