Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason to Ready condition if probe is cause and/or distinct condition for probe #481

Open
akutz opened this issue Apr 23, 2024 · 0 comments

Comments

@akutz
Copy link
Collaborator

akutz commented Apr 23, 2024

Please describe the solution you would like.

In #480, a VM was deployed with a GuestInfo-based readiness probe. However, when the Ready condition transitioned to False or True, there was no Reason associated with the condition. If a readiness probe causes the VM's Ready condition to transition to True or False, then there should be some indication that this is the Reason for the condition's value. That or there should be some distinct condition related to readiness probes.

Is there anything else you would like to add?

See above.

Please tell us about your environment.

Value How to Obtain
Supervisor version VMware-wcp-0.1.9-73863724.x86_64 rpm -qa VMware-wcp on the vCenter appliance
Supervisor node image version VMware-wcpovf-4.0.584-73832719.x86_64 rpm -qa VMware-wcpovf on the vCenter appliance
Kubernetes version Client Version: v1.28.3+vmware.wcp.1

Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

Server Version: v1.28.3+vmware.wcp.1
kubectl version
VM Operator version 0.1.0-797d737-1.8.6-40cf886-73879957
kubectl -n vmware-system-vmop get pods \
  -ojsonpath='{range .items[*].spec.containers[*]}{.image}{"\n"}{end}' | \
  sort -u | \
  grep vmop | \
  awk -F'/' '{print $3}' | \
  awk -F: '{print $2}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant