-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include example YAML files with their matching release #882
Comments
Good idea! This raises some questions:
That said, I think release tarballs should have example yaml as well as matching Docker image tags. Taking a step back, I will always advocate for the user and for first-run use (over your developer experience). Users will consistently go to github.com/heptio/ark, git clone (which gets them So, I think the I understand that this might make the Ark developer experience more challenging (you'll have to update tags yourself) as well as for folks testing Thoughts? |
I'd need to circle back on the download numbers, but the downloads on GitHub (which indicate client downloads or people building their own images) tend to be pretty low for what I'd expect.
I'm not sure I'm clear on what you're asking here. Is it a continuation of the previous point?
I think
Currently Truthfully, I mostly run the Ark server locally when I'm building, so updating and changing tags hasn't been an issue, but if I do test with an image I have to update the repository it's sent to, anyway, so I don't see this as an imposition. |
Yes - I was trying to ask if users new to Ark are more likely to download via a release tarball or via git clone. |
I assume people download our GitHub release files, at least for the The best user & first-run experience is, imho, to download a release tarball from GitHub that contains If we do this, the yaml in the repo can point at the |
So would it be accurate to describe the two following changes should happen?
|
I think only 1 is reasonable. If we do 2, there will potentially be merge conflicts if we have to backport yaml changes. |
I'm onboard 👍 |
This has been closed by #1045 |
Describe the solution you'd like
Currently, our documentation points to example YAML in git. In the cases where
master
is changing things such as adding/removing required CRDs, it's not immediately obvious that the user should be switching to the relevantrelease-
branch to get the examples and prereqs for the version of Ark that's deployed in their cluster.As an alternative, we could package the
examples
directory in to the release tarballs and update our documentation to refer to the files from the tarball. This was first proposed by @ncdc in Slack.@heptio/bluesteelsquad @rosskukulinski thoughts?
The text was updated successfully, but these errors were encountered: