Skip to content

Support per-storageclass VSC annotation #8807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cfi2017 opened this issue Mar 22, 2025 · 4 comments · May be fixed by #8646
Open

Support per-storageclass VSC annotation #8807

cfi2017 opened this issue Mar 22, 2025 · 4 comments · May be fixed by #8646
Labels
1.17-candidate

Comments

@cfi2017
Copy link

cfi2017 commented Mar 22, 2025

Describe the problem/challenge you have

On csi providers that need specific VSC settings for a single type of SC driver depending on how it's configured, such as Nutanix, the only option to use csi snapshots is currently to annotate each PVC with the relevant VSC. This is cumbersome and not well scalable if there are a lot of PVCs from different sources.

Describe the solution you'd like

We'd like to support setting a VSC in the StorageClass, which is already configured with the driver settings.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@cfi2017 cfi2017 linked a pull request Mar 22, 2025 that will close this issue
Open
3 tasks
@Lyndon-Li
Copy link
Contributor

This is a valid requirement, by our discussion, we suggest to implement it into VolumePolicy, instead of adding annotations to SC.

@cfi2017
Copy link
Author

cfi2017 commented Mar 26, 2025

This is a valid requirement, by our discussion, we suggest to implement it into VolumePolicy, instead of adding annotations to SC.

If I understand the specification correctly, we would have to implement a parameter to the action that specifies the VolumeSnapshotClass - does the current Velero version support volume snapshot actions in policies already?

@kaovilai
Copy link
Collaborator

does the current Velero version support volume snapshot actions in policies already?

yes

@cfi2017
Copy link
Author

cfi2017 commented Apr 17, 2025

does the current Velero version support volume snapshot actions in policies already?

yes

I've found the implementation in resource_policies.go. It looks like the parameters map is not used by the item_backupper at all at the moment, for none of the actions.

I also cannot find where the volume snapshot class would be configured in the backup mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.17-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(csi): allow setting annotation on StorageClass to determine VolumeSnapshotClass cfi2017/velero
3 participants
@kaovilai @cfi2017 @Lyndon-Li