Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status.Message filed has an additional single quote when bucket doesn't exist #8393

Open
PrasadJoshi12 opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@PrasadJoshi12
Copy link

What steps did you take and what happened:

Created a BSL with non-existing bucket name. Noticed the message has multiple single quotes in status.Message field. Attached bsl below:-

$ oc get bsl ts-dpa-1 -o yaml
apiVersion: velero.io/v1
kind: BackupStorageLocation
metadata:
  creationTimestamp: "2024-11-12T05:16:54Z"
  generation: 4
  labels:
    app.kubernetes.io/component: bsl
    app.kubernetes.io/instance: ts-dpa-1
    app.kubernetes.io/managed-by: oadp-operator
    app.kubernetes.io/name: oadp-operator-velero
    openshift.io/oadp: "True"
    openshift.io/oadp-registry: "True"
  name: ts-dpa-1
  namespace: openshift-adp
  ownerReferences:
  - apiVersion: oadp.openshift.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: DataProtectionApplication
    name: ts-dpa
    uid: ced515ab-5033-46b0-b72f-1fe3f4339a35
  resourceVersion: "41781"
  uid: 6235a933-ac42-450e-ae5e-c112a179c355
spec:
  credential:
    key: cloud
    name: cloud-credentials-gcp
  default: true
  objectStorage:
    bucket: oadp1016415xxlq1
    prefix: velero
  provider: gcp
status:
  lastValidationTime: "2024-11-12T05:19:19Z"
  message: 'BackupStorageLocation "ts-dpa-1" is unavailable: rpc error: code = Unknown
    desc = storage: bucket doesn''t exist'
  phase: Unavailable

What did you expect to happen:

Remove additional single quote from doesn't word.

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:

Environment:

  • Velero version (use velero version): Velero 1.14
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@blackpiglet
Copy link
Contributor

https://github.com/googleapis/google-cloud-go/blob/cbd25e917ec0ebbfe1032d94c8bdff3572365246/storage/storage.go#L62-L64

The GCP storage API's error message doesn't have the additional single quote mark.
I think this is caused by the path of error passing back.
The error is wrapped by errors.WithStack(err). That should be the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants