Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all fields in marshalling of SnapshotItemRequest and DeleteItemSnapshotRequest in item_snapshotter_client.go #4356

Closed
zubron opened this issue Nov 16, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@zubron
Copy link
Contributor

zubron commented Nov 16, 2021

This is a follow up from #4077.

We need to set the Params field in the SnapshotItemRequest object, and the SnapshotMetadata field in the DeleteItemSnapshotRequest in pkg/plugin/framework/item_snapshotter_client.go.

@zubron zubron added this to the v1.8.0 milestone Nov 16, 2021
@eleanor-millman
Copy link
Contributor

@zubron I am going through all the 1.8 milestone items as requested by @reasonerjt. I assume that this is part of the data mover work and so should stay under 1.8?

@zubron
Copy link
Contributor Author

zubron commented Nov 17, 2021

@eleanor-millman This is a small clean up task raised as part of #4077. It's part of the upload progress work so should stay in the 1.8 milestone.

@reasonerjt reasonerjt modified the milestones: v1.8.0, 1.9.0 Jan 11, 2022
@reasonerjt
Copy link
Contributor

@dsu-igeek please double check if this is already done.

@stale
Copy link

stale bot commented Mar 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Mar 22, 2022
@reasonerjt reasonerjt modified the milestones: 1.9.0, 1.10 Jun 1, 2022
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Jul 31, 2022
@stale
Copy link

stale bot commented Sep 16, 2022

Closing the stale issue.

@stale stale bot closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants