Skip to content

Commit 6337c52

Browse files
Merge pull request #8755 from sseago/csi-pvc-annotations
Move pvc annotation removal from CSI RIA to regular PVC RIA
2 parents eb5634f + fe14a2c commit 6337c52

File tree

9 files changed

+383
-480
lines changed

9 files changed

+383
-480
lines changed

changelogs/unreleased/8755-sseago

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Move pvc annotation removal from CSI RIA to regular PVC RIA

pkg/cmd/server/plugin/plugin.go

+4-12
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,6 @@ func NewCommand(f client.Factory) *cobra.Command {
9090
"velero.io/add-pvc-from-pod",
9191
newAddPVCFromPodRestoreItemAction,
9292
).
93-
RegisterRestoreItemAction(
94-
"velero.io/add-pv-from-pvc",
95-
newAddPVFromPVCRestoreItemAction,
96-
).
9793
RegisterRestoreItemAction(
9894
"velero.io/change-storage-class",
9995
newChangeStorageClassRestoreItemAction(f),
@@ -115,8 +111,8 @@ func NewCommand(f client.Factory) *cobra.Command {
115111
newCRDV1PreserveUnknownFieldsItemAction,
116112
).
117113
RegisterRestoreItemAction(
118-
"velero.io/change-pvc-node-selector",
119-
newChangePVCNodeSelectorItemAction(f),
114+
"velero.io/pvc",
115+
newPVCRestoreItemAction(f),
120116
).
121117
RegisterRestoreItemAction(
122118
"velero.io/apiservice",
@@ -308,10 +304,6 @@ func newAddPVCFromPodRestoreItemAction(logger logrus.FieldLogger) (any, error) {
308304
return ria.NewAddPVCFromPodAction(logger), nil
309305
}
310306

311-
func newAddPVFromPVCRestoreItemAction(logger logrus.FieldLogger) (any, error) {
312-
return ria.NewAddPVFromPVCAction(logger), nil
313-
}
314-
315307
func newCRDV1PreserveUnknownFieldsItemAction(logger logrus.FieldLogger) (any, error) {
316308
return ria.NewCRDV1PreserveUnknownFieldsAction(logger), nil
317309
}
@@ -352,14 +344,14 @@ func newClusterRoleBindingItemAction(logger logrus.FieldLogger) (any, error) {
352344
return ria.NewClusterRoleBindingAction(logger), nil
353345
}
354346

355-
func newChangePVCNodeSelectorItemAction(f client.Factory) plugincommon.HandlerInitializer {
347+
func newPVCRestoreItemAction(f client.Factory) plugincommon.HandlerInitializer {
356348
return func(logger logrus.FieldLogger) (any, error) {
357349
client, err := f.KubeClient()
358350
if err != nil {
359351
return nil, err
360352
}
361353

362-
return ria.NewChangePVCNodeSelectorAction(
354+
return ria.NewPVCAction(
363355
logger,
364356
client.CoreV1().ConfigMaps(f.Namespace()),
365357
client.CoreV1().Nodes(),

pkg/restore/actions/add_pv_from_pvc_action.go

-71
This file was deleted.

pkg/restore/actions/add_pv_from_pvc_action_test.go

-103
This file was deleted.

pkg/restore/actions/change_pvc_node_selector.go

-167
This file was deleted.

0 commit comments

Comments
 (0)