This repository was archived by the owner on Apr 25, 2025. It is now read-only.
feat: Move to Go Modules #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to k8s 1.17 deps to follow up of vmware-tanzu/velero changes Fix import path of kubernetes-csi/external-snapshotter/v2 Fixes #3 Signed-off-by: Alex Szakaly <[email protected]>
This is follow up change after move to Go Modules Signed-off-by: Alex Szakaly <[email protected]>
Contributor
|
@alex1989hu Thank you for your PR and apologies for not providing feedback on this PR sooner. There were some feedback comments that, I thought, would be better addressed in a PR. For that reason, I have put up PR #15 that covers this change. The same has now been merged. I am going to close this PR. Thank you again for you contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
vmware-tanzu/velerochangeskubernetes-csi/external-snapshotter/v2 (See: fix: go module requirements for semantic versioning kubernetes-csi/external-snapshotter#240)Fixes #3
Note
I can squash commits into one commit