Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of Concierge impersonation proxy via concierge CredentialIssuer. #363

Closed
mattmoyer opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement New feature or request priority/undecided Not yet prioritized

Comments

@mattmoyer
Copy link
Contributor

mattmoyer commented Jan 27, 2021

Acceptance Criteria

Scenario: configure Concierge impersonation proxy via CredentialIssuer
  Given that I have an managed cluster with the Pinniped concierge installed
  When I set some optional fields in the concierge CredentialIssuer spec
  Then I can configure the TLS certificate used to serve the impersonation proxy
  And I can configure the external name and load balancer configuration that points at the impersonation proxy
  And I can force the impersonation proxy to be turned on or off, regardless of the autodetected cloud environment
  And when I can connect to my manually-configured impersonation proxy via my custom load balancer and CA.

Notes

This is a followup to #339, which extends the minimal impersonation proxy to accept configuration. Th

API Changes

The API changes related to this issue are described in https://hackmd.io/X83kynapQgCJm_sDxXLCxg.

@margocrawf
Copy link
Contributor

margocrawf commented Jan 28, 2021

When I update the Pinniped CredentialIssuer with several new spec fields
    And I manually configure a kubeconfig that points at the external endpoint and trusts the CA

@mattmoyer were you imagining that the new CredentialIssuer fields would be integrated into anything as part of this story?

Even without any change to the CredentialIssuer it seems like the acceptance criteria should pass just from manually configuring the kubeconfig.

@mattmoyer mattmoyer changed the title Enable configuration of Concierge impersonation proxy via CredentialIssuer API. Enable configuration of Concierge impersonation proxy via concierge ConfigMap YAML. Feb 4, 2021
@mattmoyer mattmoyer added the stub Stub issues that are lacking proper descriptions label Feb 4, 2021
@mattmoyer mattmoyer removed this from the v0.6.0 milestone Feb 4, 2021
@pinniped-ci-bot pinniped-ci-bot added the priority/undecided Not yet prioritized label Feb 11, 2021
@pinniped-ci-bot pinniped-ci-bot changed the title Enable configuration of Concierge impersonation proxy via concierge ConfigMap YAML. Enable configuration of Concierge impersonation proxy via concierge CredentialIssuer YAML. Apr 13, 2021
@pinniped-ci-bot pinniped-ci-bot changed the title Enable configuration of Concierge impersonation proxy via concierge CredentialIssuer YAML. Enable configuration of Concierge impersonation proxy via concierge CredentialIssuer. Apr 13, 2021
@mattmoyer
Copy link
Contributor Author

This story is finished except for the custom CA support. I think we should close this issue until we have more validation of this use case.

@mattmoyer mattmoyer removed the stub Stub issues that are lacking proper descriptions label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/undecided Not yet prioritized
Projects
None yet
Development

No branches or pull requests

3 participants