Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table views #848

Closed
andresmgot opened this issue Nov 22, 2018 · 6 comments
Closed

Refactor table views #848

andresmgot opened this issue Nov 22, 2018 · 6 comments
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature

Comments

@andresmgot
Copy link
Contributor

We have several views in which we render tables like the Services, Deployments, Secrets, etc. of the AppView or the bindings in the ServiceView. Each of them has mostly the same component that represents the table but changing the columns content. We can create a generic component out of it.

I think we should also review the representation, I think that having a single box with different tabs for showing the different tables will provide a better UX in some cases (like the app resources).

@andresmgot andresmgot added the component/ui Issue related to kubeapps UI label Nov 22, 2018
@andresmgot andresmgot changed the title Refactor tables view Refactor table views Nov 22, 2018
@andresmgot andresmgot mentioned this issue Nov 22, 2018
2 tasks
@prydonius
Copy link
Contributor

prydonius commented Nov 26, 2018

I also think we may want to revisit whether we want tables in certain cases, there may be better ways to display some of the information we're showing. A table, to me, gives the impression of detailed information, when the goal of Kubeapps is to make things simple and consumable.

@andresmgot
Copy link
Contributor Author

Yes, but probably to display better information we may need more metadata from the chart (like knowing which secrets are credentials). In any case, I think that having raw information about all the resources for an app is something useful. Advanced users/developers can use that to see what's going on.

@prydonius
Copy link
Contributor

Advanced users/developers can use that to see what's going on.

Potentially, but I would see that level of detail as a cluster operator concern, not an app dev concern. I think it's useful to have it in a different tab for advanced info, but it should not be in the default view. Anyway, I think I'm getting away from the point of this issue, which is to create a common component we can reuse for similar views, which I do think is valuable for when we do want to show tabular information.

We may want to look at if there are any React components out there that make showing tabular data easier.

@prydonius prydonius added the kind/enhancement An issue that reports an enhancement for an implemented feature label Feb 26, 2019
@lindhe
Copy link
Contributor

lindhe commented Aug 2, 2019

My Secrets table looks broken. Does this belong here, or should I open a new issue?

It seems to be some trouble with the flex class, but I know little about HTML/CSS...

Screenshot from 2019-08-02 15-05-35

@andresmgot
Copy link
Contributor Author

yes @lindhe, that seems like a bug. Do you mind opening a different PR? we can fix the style there.

@absoludity
Copy link
Contributor

New UI has app resources in a standard table with tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Issue related to kubeapps UI kind/enhancement An issue that reports an enhancement for an implemented feature
Projects
None yet
Development

No branches or pull requests

5 participants