Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

gravity-sync purge isn't working when automation task is disabled (4.0) #322

Closed
jostrasser opened this issue Apr 12, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@jostrasser
Copy link

Issue Description

If the automation service is disabled the purge of gravity-sync will abort at the step "Disabling Gravity Sync automation service":

pi@pihole:/usr/local/bin# ./gravity-sync disable
∞ Initializing Gravity Sync (4.0.0)
✓ Evaluating arguments: DISABLE
✓ Disabling Gravity Sync automation service
✓ Removing systemd timer
✓ Removing systemd service
✓ Reloading systemd daemon
∞ Gravity Sync DISABLE completed after 1 seconds
pi@pihole:/usr/local/bin# 
pi@pihole:/usr/local/bin# ./gravity-sync purge
∞ Initializing Gravity Sync (4.0.0)
✓ Evaluating arguments: PURGE

  THIS WILL REMOVE YOUR ENTIRE GRAVITY SYNC INSTALLATION
  Pi-hole binaries, configuration and services ARE NOT impacted!
  Your devices will continue to resolve and block DNS requests,
  but your Gravity Database and DNS Records WILL NOT sync anymore,
  until you reconfigure Gravity Sync on this device.

  In order to fully remove Gravity Sync from your infrastructure, you will also
  need to run this same command from the peer instance as well.

? Type FIRE PHOTON TORPEDOES to confirm: FIRE PHOTON TORPEDOES
∞ Disabling Gravity Sync automation serviceFailed to disable unit: Unit file gravity-sync.service does not exist.
✗ Disabling Gravity Sync automation service
pi@pihole:/usr/local/bin#

@jostrasser jostrasser changed the title gravity-sync purge isn't working when automation task is disabled gravity-sync purge isn't working when automation task is disabled (4.0) Apr 12, 2022
@vmstan
Copy link
Owner

vmstan commented Apr 12, 2022

Pushed a small change 4.0.0(2) that should address this. I was monitoring for the service being active and not the timer. The service only runs when the timer tells it to, but the timer is always active if automation is enabled.

@vmstan vmstan self-assigned this Apr 12, 2022
@vmstan vmstan added the bug Something isn't working label Apr 12, 2022
@vmstan vmstan closed this as completed Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants