Skip to content

[WIP][XPU] upgrade torch-xpu to 2.12#42262

Open
jikunshang wants to merge 7 commits into
vllm-project:mainfrom
jikunshang:kunshang/torch-xpu-212
Open

[WIP][XPU] upgrade torch-xpu to 2.12#42262
jikunshang wants to merge 7 commits into
vllm-project:mainfrom
jikunshang:kunshang/torch-xpu-212

Conversation

@jikunshang

@jikunshang jikunshang commented May 11, 2026

Copy link
Copy Markdown
Member

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify

mergify Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--42262.org.readthedocs.build/en/42262/

@mergify mergify Bot added documentation Improvements or additions to documentation ci/build intel-gpu Related to Intel GPU labels May 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates XPU-related dependencies, bumping torch to 2.12.0+xpu and triton-xpu to 3.7.1, while also modifying the pre-commit configuration to exclude various torch and NVIDIA/CUDA packages from generated requirement files. Feedback highlights that the XPU installation documentation was mistakenly emptied and should be updated with the new version requirements. Additionally, there are concerns regarding the use of a test index URL and the lack of version pinning for torchaudio and torchvision, which may lead to environment instability.

I am having trouble creating individual review comments. Click here to see my feedback.

docs/getting_started/installation/gpu.xpu.inc.md (1-98)

high

The XPU installation guide content has been completely removed. This file should be updated to reflect the new version requirements (e.g., Torch 2.12 and Triton-XPU 3.7.1) rather than being emptied, as it is essential for users setting up the XPU backend.

requirements/xpu.txt (13-16)

high

The use of the test/xpu index and the lack of version pinning for torchaudio and torchvision introduce potential instability. Since torch is pinned to 2.12.0+xpu, torchaudio and torchvision should also be pinned to their matching XPU versions to ensure a consistent and reproducible environment. Furthermore, the index should be switched back to the stable one once the upgrade is finalized.

@mergify

mergify Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--42262.org.readthedocs.build/en/42262/

Comment thread .pre-commit-config.yaml Outdated
Comment on lines +131 to +187
# Exclude torch and CUDA/NVIDIA packages
--no-emit-package, torch,
--no-emit-package, torchvision,
--no-emit-package, torchaudio,
--no-emit-package, triton,
--no-emit-package, cuda-bindings,
--no-emit-package, cuda-pathfinder,
--no-emit-package, cuda-toolkit,
--no-emit-package, cupy-cuda12x,
# nvidia packages (unsuffixed / unified naming)
--no-emit-package, nvidia-cublas,
--no-emit-package, nvidia-cuda-cupti,
--no-emit-package, nvidia-cuda-nvrtc,
--no-emit-package, nvidia-cuda-runtime,
--no-emit-package, nvidia-cudnn,
--no-emit-package, nvidia-cufft,
--no-emit-package, nvidia-cufile,
--no-emit-package, nvidia-curand,
--no-emit-package, nvidia-cusolver,
--no-emit-package, nvidia-cusparse,
--no-emit-package, nvidia-cusparselt,
--no-emit-package, nvidia-nccl,
--no-emit-package, nvidia-nvjitlink,
--no-emit-package, nvidia-nvshmem,
--no-emit-package, nvidia-nvtx,
# nvidia cu12 packages
--no-emit-package, nvidia-cublas-cu12,
--no-emit-package, nvidia-cuda-cupti-cu12,
--no-emit-package, nvidia-cuda-nvrtc-cu12,
--no-emit-package, nvidia-cuda-runtime-cu12,
--no-emit-package, nvidia-cudnn-cu12,
--no-emit-package, nvidia-cufft-cu12,
--no-emit-package, nvidia-cufile-cu12,
--no-emit-package, nvidia-curand-cu12,
--no-emit-package, nvidia-cusolver-cu12,
--no-emit-package, nvidia-cusparse-cu12,
--no-emit-package, nvidia-cusparselt-cu12,
--no-emit-package, nvidia-nccl-cu12,
--no-emit-package, nvidia-nvjitlink-cu12,
--no-emit-package, nvidia-nvshmem-cu12,
--no-emit-package, nvidia-nvtx-cu12,
# nvidia cu13 packages
--no-emit-package, nvidia-cublas-cu13,
--no-emit-package, nvidia-cuda-cupti-cu13,
--no-emit-package, nvidia-cuda-nvrtc-cu13,
--no-emit-package, nvidia-cuda-runtime-cu13,
--no-emit-package, nvidia-cudnn-cu13,
--no-emit-package, nvidia-cufft-cu13,
--no-emit-package, nvidia-cufile-cu13,
--no-emit-package, nvidia-curand-cu13,
--no-emit-package, nvidia-cusolver-cu13,
--no-emit-package, nvidia-cusparse-cu13,
--no-emit-package, nvidia-cusparselt-cu13,
--no-emit-package, nvidia-nccl-cu13,
--no-emit-package, nvidia-nvjitlink-cu13,
--no-emit-package, nvidia-nvshmem-cu13,
--no-emit-package, nvidia-nvtx-cu13,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating this block please use yaml anchors like we do for mypy

- id: mypy-3.10 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
name: Run mypy for Python 3.10
entry: python tools/pre_commit/mypy.py "3.10"
<<: &mypy_common
language: python
types_or: [python, pyi]
require_serial: true
additional_dependencies: ["mypy==1.20.2", regex, types-cachetools, types-setuptools, types-PyYAML, types-requests, types-torch, pydantic]
- id: mypy-3.11 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
name: Run mypy for Python 3.11
entry: python tools/pre_commit/mypy.py "3.11"
<<: *mypy_common
stages: [manual] # Only run in CI

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question would be, why have we stopped using --torch-backend?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert it back. I tried before torch 2.12 release, with torch test channel(https://download.pytorch.org/whl/test/xpu), which will throw some compatible issue, so I follow what rocm did. I think it will no longer be a issue since torch 2.12 is released. thanks for your review!

@jikunshang jikunshang force-pushed the kunshang/torch-xpu-212 branch from 60c7bbd to 42aa309 Compare June 7, 2026 02:12
@mergify

mergify Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jikunshang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 7, 2026
jikunshang and others added 6 commits June 7, 2026 23:25
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Kunshang Ji <kunshang.ji@intel.com>
Signed-off-by: Kunshang Ji <jikunshang95@gmail.com>
@jikunshang jikunshang force-pushed the kunshang/torch-xpu-212 branch from 42aa309 to a6beabf Compare June 8, 2026 06:26
@mergify mergify Bot removed the needs-rebase label Jun 8, 2026
@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jikunshang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation intel-gpu Related to Intel GPU needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants