[Bugfix] Accept canonicalized modelopt_* quant_method in _extract_modelopt_quant_algo#42181
Merged
Merged
Conversation
vadiklyutiy
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth and
yewentao256
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request updates the _extract_modelopt_quant_algo function in vllm/model_executor/layers/quantization/modelopt.py to check if the quant_method starts with "modelopt" instead of requiring an exact match. This change allows for more flexible quantization method naming. I have no feedback to provide as no review comments were present.
yewentao256
approved these changes
May 9, 2026
yewentao256
left a comment
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
yewentao256
approved these changes
May 11, 2026
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
h1t35h
pushed a commit
to h1t35h/vllm
that referenced
this pull request
May 21, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
…modelopt_quant_algo` (vllm-project#42181) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelArchConfigConvertorBase._normalize_quantization_configrewritesquant_methodto the family-specific name (e.g."modelopt_fp4"for the legacyhf_quant_config.jsonshape withquant_algo: "NVFP4")._extract_modelopt_quant_algothen strict-equals against"modelopt"and returnsNone, so the override loop inModelConfig._verify_quantizationfinds no match and validation raises:This was hitting
nvidia/Qwen3.5-397B-A17B-NVFP4with--quantization modeloptintermittently — one of several spawn-context API-server processes resolved the legacyhf_quant_config.jsoninstead of the modernconfig.jsonand the strict check tipped it over.Replace the equality with
startswith("modelopt"). Covers all four registered variants (modelopt,modelopt_fp4,modelopt_mxfp8,modelopt_mixed) and matches whathumming.py(config["quant_method"] in [..., "modelopt"]) andutils/torch_utils.py:315(quant_method.startswith("modelopt")) already accept.