Skip to content

Add @Harry-Chen in CODEOWNERS#42130

Merged
Isotr0py merged 1 commit into
vllm-project:mainfrom
Harry-Chen:codeowner
May 9, 2026
Merged

Add @Harry-Chen in CODEOWNERS#42130
Isotr0py merged 1 commit into
vllm-project:mainfrom
Harry-Chen:codeowner

Conversation

@Harry-Chen

@Harry-Chen Harry-Chen commented May 9, 2026

Copy link
Copy Markdown
Member

Purpose

Add me to the CODEOWNERS file.

Test Plan

N/A

Test Result

N/A


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copilot AI review requested due to automatic review settings May 9, 2026 03:30

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to add @Harry-Chen as a maintainer for CMakeLists.txt, the /cmake directory, .buildkite, and the docker/Dockerfile. The review feedback suggests adding leading slashes to the .buildkite and docker/Dockerfile paths to ensure they are anchored to the repository root and maintain consistency with other entries in the file.

Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated

# CI & building
.buildkite @Harry-Chen
docker/Dockerfile @Harry-Chen

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For consistency with other Dockerfile definitions in this file (e.g., lines 136, 141, and 170) and to explicitly anchor the path to the root, please add a leading slash.

/docker/Dockerfile @Harry-Chen

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CODEOWNERS rules to add @Harry-Chen as an owner for build- and CMake-related areas.

Changes:

  • Add @Harry-Chen as a CODEOWNER for the root CMakeLists.txt and the /cmake directory.
  • Add CODEOWNERS entries for CI/build artifacts under .buildkite and docker/Dockerfile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/CODEOWNERS Outdated
Comment thread .github/CODEOWNERS Outdated
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>

@Isotr0py Isotr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!

@Isotr0py Isotr0py enabled auto-merge (squash) May 9, 2026 03:43
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 9, 2026
@Isotr0py Isotr0py merged commit 97cc768 into vllm-project:main May 9, 2026
13 checks passed
@Harry-Chen Harry-Chen deleted the codeowner branch May 9, 2026 04:43
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528 pushed a commit to knight0528/vllm that referenced this pull request Jun 8, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants