Add @Harry-Chen in CODEOWNERS#42130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to add @Harry-Chen as a maintainer for CMakeLists.txt, the /cmake directory, .buildkite, and the docker/Dockerfile. The review feedback suggests adding leading slashes to the .buildkite and docker/Dockerfile paths to ensure they are anchored to the repository root and maintain consistency with other entries in the file.
|
|
||
| # CI & building | ||
| .buildkite @Harry-Chen | ||
| docker/Dockerfile @Harry-Chen |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CODEOWNERS rules to add @Harry-Chen as an owner for build- and CMake-related areas.
Changes:
- Add
@Harry-Chenas a CODEOWNER for the rootCMakeLists.txtand the/cmakedirectory. - Add CODEOWNERS entries for CI/build artifacts under
.buildkiteanddocker/Dockerfile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
jeejeelee
approved these changes
May 9, 2026
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528
pushed a commit
to knight0528/vllm
that referenced
this pull request
Jun 8, 2026
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add me to the
CODEOWNERSfile.Test Plan
N/A
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.