Skip to content

[Refactor] Cleanup batch invariant dead code#41993

Merged
yewentao256 merged 3 commits into
mainfrom
wentao-cleanup-batch-invariant-dead-code
May 11, 2026
Merged

[Refactor] Cleanup batch invariant dead code#41993
yewentao256 merged 3 commits into
mainfrom
wentao-cleanup-batch-invariant-dead-code

Conversation

@yewentao256

Copy link
Copy Markdown
Member

Purpose

Cleanup batch invariant dead code

Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs cleanup in the batch_invariant module, including the removal of unused imports, includes, and commented-out code. It simplifies _matmul_launch_metadata and removes logic that previously cached original state values when enabling batch invariant mode. I have no feedback to provide.

@LucasWilkinson LucasWilkinson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for cleaning this up!

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Land it as all CI pass

@yewentao256 yewentao256 merged commit 4b64fc2 into main May 11, 2026
162 checks passed
@yewentao256 yewentao256 deleted the wentao-cleanup-batch-invariant-dead-code branch May 11, 2026 14:48
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
h1t35h pushed a commit to h1t35h/vllm that referenced this pull request May 21, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528 pushed a commit to knight0528/vllm that referenced this pull request Jun 8, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants