[ROCm][CI] Remove TORCH_NCCL_BLOCKING_WAIT=1 After Bugfix In ROCm 7.2#41840
Merged
robertgshaw2-redhat merged 3 commits intoMay 6, 2026
Merged
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
…T=1" This reverts commit c219c11. Signed-off-by: Micah Williamson <micah.williamson@amd.com>
…ROCm 7.2 Signed-off-by: Micah Williamson <micah.williamson@amd.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the TORCH_NCCL_BLOCKING_WAIT=1 environment variable export from multiple test steps within the .buildkite/test-amd.yaml configuration file. These changes affect various distributed, collective RPC, and model-specific test suites on AMD platforms. I have no feedback to provide as there were no review comments to evaluate.
robertgshaw2-redhat
approved these changes
May 6, 2026
github-actions
Bot
added
the
ready
libinta
pushed a commit
to libinta/vllm
that referenced
this pull request
May 8, 2026
….2 (vllm-project#41840) Signed-off-by: Micah Williamson <micah.williamson@amd.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
….2 (vllm-project#41840) Signed-off-by: Micah Williamson <micah.williamson@amd.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
….2 (vllm-project#41840) Signed-off-by: Micah Williamson <micah.williamson@amd.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
….2 (vllm-project#41840) Signed-off-by: Micah Williamson <micah.williamson@amd.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
….2 (vllm-project#41840) Signed-off-by: Micah Williamson <micah.williamson@amd.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of ROCm 7.2, the
TORCH_NCCL_BLOCKING_WAIT=1workaround is no longer needed for distributed test groups on ROCm. The fix here: ROCm/rocm-systems#2177 was merged to address the issue tracked here ROCm/hip#3876. Here is a CI build with the affected TGs which show them passing withoutTORCH_NCCL_BLOCKING_WAIT=1: https://buildkite.com/vllm/amd-ci/builds/8262/canvas?sid=019dfdb2-1e62-4b4b-885a-b7ddaecc82cb&tab=output (note that the failures there are present on main).