Cherrypick --omni Entrypoint Handling (40744) for v.0.20.0#40947
Closed
alex-jw-brooks wants to merge 10 commits into
Closed
Cherrypick --omni Entrypoint Handling (40744) for v.0.20.0#40947alex-jw-brooks wants to merge 10 commits into
alex-jw-brooks wants to merge 10 commits into
Conversation
… github from rocm.txt e.g `fastsafetensors` as it is incompatible with `uv pip` (vllm-project#40461) Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> (cherry picked from commit 583e6f2)
…lm-project#40349) Signed-off-by: NickLucche <nlucches@redhat.com> (cherry picked from commit 304d5ba)
…llm-project#39391) Signed-off-by: Jhao-Ting Chen <jhaotingc@nvidia.com> (cherry picked from commit 28c2221)
…llm-project#40276) Co-authored-by: Roger Wang <hey@rogerw.io> (cherry picked from commit 67eb608)
Replaces manual docker publish instructions in annotate-release.sh with a unified publish-release-images.sh script and corresponding Buildkite pipeline steps. The new script handles all image variants (CUDA 12.9, CUDA 13.0, Ubuntu 24.04, ROCm, and CPU), automating the pull, tag, push, and multi-arch manifest creation for Docker Hub releases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: khluu <khluu000@gmail.com>
…clean up stale build-args (vllm-project#39878) Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> (cherry picked from commit 3ed5231)
…0744) Signed-off-by: Alex Brooks <albrooks@redhat.com>
alex-jw-brooks
requested review from
DarkLight1337,
hmellor,
mgoin and
russellb
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
alex-jw-brooks
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a delegation mechanism in the CLI to hand over execution to vllm-omni when the --omni flag is present. The feedback suggests refactoring the implementation to use an early return pattern to avoid unnecessary nesting and improve readability. Additionally, the reviewer noted that checking sys.argv directly for the flag is fragile and could lead to false positives.
DarkLight1337
added
the
ready
khluu
requested review from
LucasWilkinson,
WoosukKwon,
gshtras,
tjtanaa,
tlrmchlsmth and
yewentao256
as code owners
Contributor
|
Documentation preview: https://vllm--40947.org.readthedocs.build/en/40947/ |
mergify
Bot
added
documentation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Kevin H. Luu <khluu000@gmail.com>
Member
|
closing because #40744 is already in the branch cut |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry pick of #40744 for
0.20.0CC @ywang96 @hsliuustc0106 @lishunyang12