Revert "Add nightly b200 test for spec decode eagle correctness (#38577)"#39512
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes several nightly test configurations for speculative decoding on B200 devices from the Buildkite test area specification, including Eagle, Speculators + MTP, and Draft Model tests. I have no feedback to provide.
…-project#38577)" This reverts commit adaabb8. Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
benchislett
force-pushed
the
revert-eagle-test
branch
from
c5514ea to
65d4da1
Compare
SageMoore
approved these changes
Apr 10, 2026
LucasWilkinson
approved these changes
Apr 10, 2026
wojciech-wais
pushed a commit
to wojciech-wais/vllm
that referenced
this pull request
Apr 13, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
stecasta
added a commit
to stecasta/vllm
that referenced
this pull request
Apr 21, 2026
Re-applies the 3 optional nightly B200 buildkite steps originally added in vllm-project#38577 and reverted in vllm-project#39512. The revert was due to the Blackwell specdec correctness regression; the preceding commit in this PR fixes the underlying bug. Addresses Matthew Bonanni's review ask to re-enable the previously failing tests and confirm they pass CI. Co-authored-by: Rishi Puri <riship@nvidia.com> Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
stecasta
added a commit
to stecasta/vllm
that referenced
this pull request
Apr 21, 2026
…m-project#38577)" (vllm-project#39512) This reverts commit af661a1. Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
stecasta
added a commit
to puririshi98/vllm
that referenced
this pull request
Apr 21, 2026
…m-project#38577)" (vllm-project#39512) This reverts commit af661a1. Signed-off-by: Stefano Castagnetta <scastagnetta@nvidia.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…-project#38577)" (vllm-project#39512) Signed-off-by: Benjamin Chislett <bchislett@nvidia.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit adaabb8. Failing in nightly CI.
see: #39441