[Deprecation] Deprecate cprofile and cprofile_context#39100
Merged
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Contributor
|
Documentation preview: https://vllm--39100.org.readthedocs.build/en/39100/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates the vllm.utils.profiling helper functions, specifically cprofile and cprofile_context, in favor of using Python's native cProfile module. The changes include updating the documentation and adding @deprecated decorators to the functions in vllm/utils/profiling.py, with a planned removal in version v0.21. I have no feedback to provide.
Member
Author
Member
|
cc @youkaichao |
Member
Author
|
Hi @DarkLight1337 Seems that @youkaichao is very busy recently, I don't think this part is risky to remove as not used at all. Wondering if you could help land it? Thanks! |
DarkLight1337
approved these changes
Apr 21, 2026
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Ok let's move forward with this then.
khluu
pushed a commit
that referenced
this pull request
Apr 22, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com> (cherry picked from commit 301024a)
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
Apr 22, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Apr 23, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Apr 23, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Yifan <yzong@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Lafunamor
pushed a commit
to Lafunamor/vllm
that referenced
this pull request
May 1, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Adrian <info@zzit.ch>
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
May 7, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…9100) Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Deprecate cprofile and cprofile_context as these are not used at all inside vLLM
But since we have document describing this so it is a better idea to go for a deprecate period instead of deleting it directly.