[PluggableLayer][MM] Add PluggableLayer for CustomQwen2Decoder#37293
Merged
Conversation
Signed-off-by: Wangbei25 <wangbei41@huawie.com>
Signed-off-by: Wangbei25 <wangbei41@huawie.com>
Contributor
|
Documentation preview: https://vllm--37293.org.readthedocs.build/en/37293/ |
mergify
Bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors CustomQwen2Decoder to be a PluggableLayer, which is a good step for extensibility. The documentation is also updated to reflect this and other related changes. My review includes a couple of suggestions to fix path separators in the documentation, which will ensure the documentation builds correctly across different operating systems.
| **12. Encoder:** | ||
|
|
||
| ```python | ||
| --8<-- "vllm\model_executor\models\deepencoder2.py:qwen2_decoder" |
Contributor
There was a problem hiding this comment.
The file path here uses a backslash (\) as a separator. For cross-platform compatibility and consistency with other paths in this document, please use a forward slash (/).
Suggested change
| --8<-- "vllm\model_executor\models\deepencoder2.py:qwen2_decoder" | |
| --8<-- "vllm/model_executor/models/deepencoder2.py:qwen2_decoder" |
Signed-off-by: Wangbei25 <wangbei41@huawei.com>
Contributor
|
@ProExpertProg Would you mind take a look at this PR? Just a minor refactor for pluggable layer. |
ProExpertProg
approved these changes
Mar 20, 2026
github-actions
Bot
added
the
ready
chooper26
pushed a commit
to vLLM-HUST/vllm-hust
that referenced
this pull request
Mar 21, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…project#37293) Signed-off-by: Wangbei25 <wangbei41@huawie.com> Signed-off-by: Wangbei25 <wangbei41@huawei.com> Co-authored-by: Wangbei25 <wangbei41@huawie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add PluggableLayer for CustomQwen2Decoder. As a result, this kind of encoder can be replaced with custom OOT implementations.
Test Plan
vllm serve /weights/DeepSeek-OCR-2
--served-model-name deepseekocr2
--trust-remote-code
curl http://localhost:1055/v1/chat/completions
-H "Content-Type: application/json"
-d '{"model": "deepseekocr2","messages": [{"role": "user","content": [
{"type": "image_url","image_url": {"url": "file:///datasets/textvqa_val/train_images/1080p.jpg","detail": "high"}},
{"type": "text","text": "Explain the contents of the picture with more than 500 words"}]}],
"max_tokens": 300
}'
Test Result
{"id":"chatcmpl-9be9f1663df4218e","object":"chat.completion","created":1773060077,"model":"deepseekocr2","choices":[{"index":0,"message":{"role":"assistant","content":"Ixar sampled a moment on the edge of a sandy beach. The white dog, sitting on its hind legs, looks directly at the camera. The person, dressed in a blue and white plaid shirt, sits on the sand with their legs crossed. In the background, the vast expanse of the ocean stretches out. The sun is setting, adding a warm glow to the scene. The image captures a peaceful moment between a dog and a person on a beach at sunset.","refusal":null,"annotations":null,"audio":null,"function_call":null,"tool_calls":[],"reasoning":null},"logprobs":null,"finish_reason":"stop","stop_reason":null,"token_ids":null}],"service_tier":null,"system_fingerprint":null,"usage":{"prompt_tokens":559,"total_tokens":656,"completion_tokens":97,"prompt_tokens_details":null},"prompt_logprobs":null,"prompt_token_ids":null,"kv_transfer_params":null}
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.