Skip to content

[MISC] Removed unused function find_all_indices() from tool_parsers/utils.py - #35683

Merged
DarkLight1337 merged 2 commits into
vllm-project:mainfrom
taneem-ibrahim:remove_find_all_indices
Mar 3, 2026
Merged

[MISC] Removed unused function find_all_indices() from tool_parsers/utils.py#35683
DarkLight1337 merged 2 commits into
vllm-project:mainfrom
taneem-ibrahim:remove_find_all_indices

Conversation

@taneem-ibrahim

@taneem-ibrahim taneem-ibrahim commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Purpose

Removed unused find_all_indices() from tool_parsers/utils.py to reduce irrelevant code. The code is not used anywhere.

Test Plan

N/A

Test Result

N/A

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the find_all_indices function from vllm/tool_parsers/utils.py. This change is a code cleanup, as the function appears to be unused within the provided context.

@yewentao256 yewentao256 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 2, 2026
@DarkLight1337
DarkLight1337 merged commit 3a6cbf1 into vllm-project:main Mar 3, 2026
48 of 49 checks passed
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Mar 12, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
@taneem-ibrahim
taneem-ibrahim deleted the remove_find_all_indices branch May 17, 2026 17:09
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants