From 7da99d2e07e4dd9849ebfdd8e5a5dc7ef7e465df Mon Sep 17 00:00:00 2001 From: Randall Smith Date: Tue, 24 Feb 2026 02:05:37 +0000 Subject: [PATCH 1/4] skip if no ibv available Signed-off-by: Randall Smith --- .../kv_connector/unit/test_moriio_connector.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tests/v1/kv_connector/unit/test_moriio_connector.py b/tests/v1/kv_connector/unit/test_moriio_connector.py index 1eca4964fd6c..142ea71a2131 100644 --- a/tests/v1/kv_connector/unit/test_moriio_connector.py +++ b/tests/v1/kv_connector/unit/test_moriio_connector.py @@ -46,6 +46,24 @@ ) +def is_ibverbs_available(): + from shutil import which + + print(f"which = {which('ibv_devices')}") + if which("ibv_devices") is None: + return False + from subprocess import check_output + + output = check_output(["ibv_devices"]).decode("UTF-8") + if len(output.split("\n")) < 12: + return False + return True + + +if not is_ibverbs_available(): + pytest.skip("This test requires IB Verbs to run", allow_module_level=True) + + @pytest.fixture def mock_parallel_groups(): """Mock tensor/data parallel group functions for single-rank tests.""" From cdc2c8a4539f6f8a7c3fd714044a31f78804ce6a Mon Sep 17 00:00:00 2001 From: Randall Smith Date: Tue, 24 Feb 2026 02:36:46 +0000 Subject: [PATCH 2/4] just check if ibv_devices is empty Signed-off-by: Randall Smith --- tests/v1/kv_connector/unit/test_moriio_connector.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/v1/kv_connector/unit/test_moriio_connector.py b/tests/v1/kv_connector/unit/test_moriio_connector.py index 142ea71a2131..845ffe819b98 100644 --- a/tests/v1/kv_connector/unit/test_moriio_connector.py +++ b/tests/v1/kv_connector/unit/test_moriio_connector.py @@ -55,7 +55,7 @@ def is_ibverbs_available(): from subprocess import check_output output = check_output(["ibv_devices"]).decode("UTF-8") - if len(output.split("\n")) < 12: + if len(output.split("\n")) == 3: return False return True From da870942ad0c339dea2d10c7be539ce354da4a94 Mon Sep 17 00:00:00 2001 From: Randall Smith Date: Tue, 24 Feb 2026 02:37:40 +0000 Subject: [PATCH 3/4] remove print statement Signed-off-by: Randall Smith --- tests/v1/kv_connector/unit/test_moriio_connector.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/v1/kv_connector/unit/test_moriio_connector.py b/tests/v1/kv_connector/unit/test_moriio_connector.py index 845ffe819b98..dbf2865dce6a 100644 --- a/tests/v1/kv_connector/unit/test_moriio_connector.py +++ b/tests/v1/kv_connector/unit/test_moriio_connector.py @@ -49,7 +49,6 @@ def is_ibverbs_available(): from shutil import which - print(f"which = {which('ibv_devices')}") if which("ibv_devices") is None: return False from subprocess import check_output From 60b671921674d5466029fc721d143737ed122227 Mon Sep 17 00:00:00 2001 From: Randall Smith Date: Tue, 24 Feb 2026 03:41:04 +0000 Subject: [PATCH 4/4] return condition directly Signed-off-by: Randall Smith --- tests/v1/kv_connector/unit/test_moriio_connector.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/v1/kv_connector/unit/test_moriio_connector.py b/tests/v1/kv_connector/unit/test_moriio_connector.py index dbf2865dce6a..76ca9e14a95d 100644 --- a/tests/v1/kv_connector/unit/test_moriio_connector.py +++ b/tests/v1/kv_connector/unit/test_moriio_connector.py @@ -54,9 +54,7 @@ def is_ibverbs_available(): from subprocess import check_output output = check_output(["ibv_devices"]).decode("UTF-8") - if len(output.split("\n")) == 3: - return False - return True + return len(output.split("\n")) > 3 if not is_ibverbs_available():