[CI] Actually run tests/kernels/quantization/test_block_fp8.py in CI - #34274
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a great step towards improving CI coverage. By removing the deep_gemm filter, you're enabling a much broader set of tests for block FP8 quantization, which will help catch regressions and ensure kernel correctness across different hardware. The fixes to the test cases, including updating test parameters and correcting the logic in test_w8a8_block_fp8_cutlass_matmul, are valuable for making the test suite more robust and reliable. The changes look solid and well-aligned with the goal of improving test quality.
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
|
|
||
| # Test configurations | ||
| DTYPES = [torch.bfloat16] # [torch.half, torch.bfloat16, torch.float32] | ||
| # Quantization test configs |
There was a problem hiding this comment.
| # Quantization test configs |
Seems not needed
|
Requires flashinfer-ai/flashinfer#2533 to be released and updated in vllm |
2 participants
Signed-off-by: mgoin mgoin64@gmail.com
Purpose
We were only running the deepgemm tests in
tests/kernels/quantization/test_block_fp8.pysince we had not H100 runner running the rest of the file. I also fixed some outdated test cases after kernel updates like #28431Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.