[Refactor] Remove unused file pallas_kv_cache_update.py - #32433
Merged
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the file vllm/v1/attention/ops/pallas_kv_cache_update.py. After reviewing the provided context, I can confirm that this file appears to be unused, as there are no references to its functions (_kv_cache_update_kernel, kv_cache_update) in the rest of the codebase. Removing dead code is a good practice that improves maintainability. This change is a positive refactoring and appears safe to merge.
Collaborator
|
@yewentao256 thanks for catching this file. It should be deleted last time when tpu executor was removed. |
yaochengji
enabled auto-merge (squash)
January 15, 2026 23:05
github-actions
Bot
added
the
ready
ywang96
disabled auto-merge
January 18, 2026 20:46
gopalsarda
pushed a commit
to gopalsarda/vllm
that referenced
this pull request
Jan 20, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…ct#32433) Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Seems introduced in #19928
But this function now is not used anywhere, not sure if we can delete it
CC: @yaochengji