[CI] refine more logic when generating and using nightly wheels & indices, add cuda130 build for aarch64, specify correct manylinux version#30341
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refines the logic for handling nightly and release wheels. The changes in .buildkite/scripts/generate-nightly-index.py to filter wheels for non-nightly versions are a good step, but the implementation has a flaw that could lead to including development wheels in release indices. I've suggested a more robust filtering logic. Additionally, the shell script for testing python-only compilation has been improved with a retry mechanism. However, the JSON validation step unnecessarily prints the entire file to the logs, which I've provided a fix for to improve log cleanliness and avoid potential issues with log size.
There was a problem hiding this comment.
Pull request overview
This PR refines the CI logic for generating and using nightly wheels and indices, focusing on improved error handling and proper filtering of release wheels.
Key Changes:
- Added automatic retry logic (5 attempts, 3-minute intervals) with user-friendly error messages for metadata.json URL validation in the python-only installation test
- Implemented filtering to exclude dev wheels from release wheel indices, ensuring only official release wheels are included
- Enhanced error messages throughout with consistent severity prefixes (INFO, WARNING, ERROR, CRITICAL)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/standalone_tests/python_only_compile.sh |
Added retry logic with metadata.json URL validation and improved error messages for python-only compilation tests |
.buildkite/scripts/upload-wheels.sh |
Added re-generation of indices specifically for release versions to exclude non-release wheels |
.buildkite/scripts/generate-nightly-index.py |
Implemented version detection and filtering logic to exclude dev wheels from release indices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…cript Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…ating indices Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Harry-Chen
force-pushed
the
nightly-wheel-warning
branch
from
0d2dfe6 to
b588306
Compare
Harry-Chen
changed the title
github-actions
Bot
added
the
ready
|
This is also useful for running on a Raspberry Pi with multiple GPUs, so thank you! |
…ices, add cuda130 build for aarch64, specify correct manylinux version (vllm-project#30341) Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
…ices, add cuda130 build for aarch64, specify correct manylinux version (vllm-project#30341) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…ices, add cuda130 build for aarch64, specify correct manylinux version (vllm-project#30341) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…ices, add cuda130 build for aarch64, specify correct manylinux version (vllm-project#30341) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…ices, add cuda130 build for aarch64, specify correct manylinux version (vllm-project#30341) Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Purpose
This PR further fixes some corner cases when generating and using nightly wheels / indices, including:
It also:
Test Plan
Tested by CI.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.