Use official xformers-0.0.33 built for PT 2.9 #28600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the xformers dependency to the official 0.0.33 release for PyTorch 2.9, replacing a custom-built version. This is an excellent change that improves maintainability and stability by relying on an official package. The modification is straightforward and correct. I have reviewed the changes and found no issues.
ProExpertProg
approved these changes
Nov 13, 2025
EmilienM
approved these changes
Nov 13, 2025
mgoin
approved these changes
Nov 13, 2025
ywang96
approved these changes
Nov 13, 2025
Member
ywang96
left a comment
ywang96
left a comment
There was a problem hiding this comment.
I think this PR is now good to be force-merged. All failed tests are not related to this dependency change but we should address them separately.
This was referenced Nov 13, 2025
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
Signed-off-by: Huy Do <[email protected]> Co-authored-by: Roger Wang <[email protected]> Signed-off-by: George D. Torres <[email protected]>
khluu
pushed a commit
that referenced
this pull request
Nov 16, 2025
Signed-off-by: Huy Do <[email protected]> Co-authored-by: Roger Wang <[email protected]> (cherry picked from commit c33b87e)
bwasti
pushed a commit
to bwasti/vllm
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Huy Do <[email protected]> Co-authored-by: Roger Wang <[email protected]> Signed-off-by: Bram Wasti <[email protected]>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Huy Do <[email protected]> Co-authored-by: Roger Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
xformers-0.0.33has been released today for PyTorch 2.9 https://pypi.org/project/xformers/#history, and we can finally switch to that version instead of the custom one we build on PyTorchFIX #27880 #27851
Test Plan
CI
cc @simon-mo @ywang96 @ProExpertProg