-
-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[Attention] Bump FA for removed method #28429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matthew Bonanni <[email protected]>
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the flash-attention dependency. However, this change introduces two critical issues. First, the new dependency version removes the flash_attn_with_kvcache function, but this function is still used in the test file tests/kernels/attention/test_flash_attn.py, which will likely cause the tests to fail. The test code needs to be updated to reflect this change in the dependency. Second, the dependency now points to a temporary branch on a personal fork. This is a major risk for build stability and security, and it should be pointed to an official repository and a stable commit/tag before merging into a main branch.
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]>
|
Wow, it looks like we see a 20% reduction in wheel size (481MB --> 380MB) |
Signed-off-by: Matthew Bonanni <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: George D. Torres <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Bram Wasti <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Matthew Bonanni <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Purpose
vLLM-side PR for vllm-project/flash-attention#107. Removes unused
flash_attn_with_kvcacheand sets flags for build speedup + size reduction.It looks like we see a 20% reduction in wheel size (481MB --> 380MB)
Recent commit on main:
This PR:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.